Use newer npm version in Docker UI build
#17064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #17064 will not alter performanceComparing Summary
|
desertaxle
commented
Feb 9, 2025
| @@ -14,7 +14,7 @@ ARG NODE_VERSION=18.18.0 | |||
| ARG EXTRA_PIP_PACKAGES="" | |||
|
|
|||
| # Build the UI distributable. | |||
| FROM node:${NODE_VERSION}-bullseye-slim AS ui-builder | |||
| FROM --platform=$BUILDPLATFORM node:${NODE_VERSION}-bullseye-slim AS ui-builder | |||
There was a problem hiding this comment.
This is the key change right here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker builds have been running offensively long when running
npm ci. This wasn't shown in our Docker build benchmark because we were only building foramd64andarm64was causing the issue. I belive the issue is because some of thenpmdependeices (namelyesbuilt) rely on C binaries that need to be recompiles forarm64.This PR updates the Docker build benchmark workflow to perform a multi-platform build to get a more accurate read of build performance. It also updates the Dockerfile to only run the UI build step for the current build platform. Since the UI build step produces static HTML, JS, and CSS files, it is not platform-dependent. The result of this change is a ~90% reduction in build time.