Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Refines flow run card in replacement for flow run data table #17242

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[UI v2] feat: Refines flow run card in replacement for flow run data table #17242

wants to merge 1 commit into from

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 21, 2025 •
edited
Loading

Refines flow run card in replacement for flow run data table

  1. Removes flow run data table components in favor for the card UX
  2. Updates and refines flow run card component

Upcoming PR, will update the hook to join deployment data to the flow run

Screen.Recording.2025-02-21.at.1.49.19.PM.mov
Screen.Recording.2025-02-21.at.1.44.15.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 21, 2025
devinvillarosa
devinvillarosa commented Feb 21, 2025
View reviewed changes
ui-v2/src/components/ui/typography/styles.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding support for text-xs sizing

@devinvillarosa devinvillarosa marked this pull request as ready for review February 21, 2025 21:51
@devinvillarosa devinvillarosa marked this pull request as draft February 21, 2025 22:04
@devinvillarosa devinvillarosa marked this pull request as ready for review February 21, 2025 22:15
@devinvillarosa devinvillarosa force-pushed the refine-flow-runs-card branch 3 times, most recently from 8dc27af to 3c32c67 Compare February 21, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@devangrose devangrose Awaiting requested review from devangrose devangrose is a code owner

@pleek91 pleek91 Awaiting requested review from pleek91 pleek91 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@devinvillarosa