Extend visit_collection with support for annotations
#7263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
4 tasks
3 tasks
zanieb
commented
Jan 3, 2023
src/prefect/engine.py
Outdated
| @@ -1418,7 +1412,7 @@ def resolve_input(expr): | |||
| # Do not allow uncompleted upstreams except failures when `allow_failure` has | |||
| # been used | |||
| if not state.is_completed() and not ( | |||
| should_allow_failure and state.is_failed() | |||
| isinstance(context.get("annotation"), allow_failure) and state.is_failed() | |||
There was a problem hiding this comment.
Hm. This will break when annotations are nested e.g. allow_failure(quote("foo")) — maybe I should make the context have a list or set of annotations?
There was a problem hiding this comment.
That makes sense to me - it seems that you could even change the key name to annotations without any backwards compatible breakage since the flow is re-parsed with each run
There was a problem hiding this comment.
I'm going to wait for this to be an actual issue so we can keep this simple and get it out there
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Moved to `prefect.utilities.annotations` but preserved here for compatibility | ||
| from prefect.utilities.annotations import Quote, quote # noqa | ||
| # Quote moved to `prefect.utilities.annotations` but preserved here for compatibility | ||
| from prefect.utilities.annotations import BaseAnnotation, Quote, quote # noqa |
Check notice
Code scanning / CodeQL
Unused import
peytonrunyan
reviewed
Jan 4, 2023
|
@peytonrunyan please re-review |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
masonmenges
pushed a commit
that referenced
this pull request
Jan 10, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 12, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 19, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Jan 26, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
3 tasks
zanieb
added a commit
that referenced
this pull request
Feb 3, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
zanieb
added a commit
that referenced
this pull request
Feb 3, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
zanieb
added a commit
that referenced
this pull request
Feb 6, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
zanieb
added a commit
that referenced
this pull request
Feb 6, 2023
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #7248 but solves PrefectHQ/prefect-dask#43 without requiring the changes in PrefectHQ/prefect-dask#45
There is a new
contextdictionary onvisit_collection. It isNoneby default and ignored. If set, it can be used to store contextual information that persists asvisit_collectiondescends into nested items. A shallow copy is used to prevent the changes from leaking "up".This
contextdictionary is populated with an annotation when descending into annotations. Previously,visit_collectionwould never descend into annotations. We now explicitly do not parse object within quotes in the engine instead of relying onvisit_collectionto ignore it.Additionally,
visit_collectionnow has aremove_annotations: bool = Falsesetting that is used duringresolve_inputsto strip annotations from inputs while preserving other behavior i.e. visiting the items within the annotation.Checklist
<link to issue>"fix,feature,enhancement