Adds migration logic for work pools #8214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for prefect-orion ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
desertaxle
force-pushed
the
work-pool-deployments-refactor
branch
from
1b5fb57 to
2d220ea
Compare
desertaxle
changed the title
desertaxle
changed the title
cicdw
reviewed
Jan 24, 2023
There was a problem hiding this comment.
initial pass - I think the DB logic would benefit from a review by @zangell44 if feasible
zangell44
reviewed
Jan 24, 2023
| Can be run at any time to facilitate user-initiated migrations without | ||
| waiting for an agent to poll. | ||
| """ | ||
| for work_queue in await models.work_queues.read_work_queues(session=session): |
There was a problem hiding this comment.
Might be worth adding some batching here
zangell44
reviewed
Jan 24, 2023
cicdw
approved these changes
Jan 24, 2023
cicdw
approved these changes
Jan 25, 2023
ddelange
added a commit
to ddelange/prefect
that referenced
this pull request
Jan 26, 2023
…erm-testing * 'main' of https://github.com/prefecthq/prefect: (77 commits) Update roles and permissions in documentation (PrefectHQ#8263) Add Prefect Cloud Quickstart tutorial (PrefectHQ#8227) Remove needless log Update comment for consistency Reorder migrations for clarity Refactor cancellation cleanup service Uses canonical `CANCELLING` states for run cancellations (PrefectHQ#8245) Add cancellation cleanup service (PrefectHQ#8128) Improve engine shutdown handling of SIGTERM (PrefectHQ#8127) Create a `CANCELLING` state type (PrefectHQ#7794) Update KubernetesJob options (PrefectHQ#8261) Small work pools UI updates (PrefectHQ#8257) Removes migration logic (PrefectHQ#8255) Consolidate multi-arch docker builds (PrefectHQ#7902) Include nested `pydantic.BaseModel` secret fields in blocks' schema (PrefectHQ#8246) Improve contributing documentation with venv instructions (PrefectHQ#8247) Update Python tests to use a single test matrix for both databases (PrefectHQ#8171) Adds migration logic for work pools (PrefectHQ#8214) Add `project_urls` to `setup.py` (PrefectHQ#8224) Add `is_schedule_active` to client `Deployment` class (PrefectHQ#7430) ...
3 tasks
zanieb
pushed a commit
that referenced
this pull request
Feb 3, 2023
zanieb
pushed a commit
that referenced
this pull request
Feb 3, 2023
zanieb
pushed a commit
that referenced
this pull request
Feb 6, 2023
zanieb
pushed a commit
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functionality to duplicate existing work queues to corresponding work pool queues. All migration logic is hidden behind the
PREFECT_EXPERIMENTAL_ENABLE_WORK_POOLsetting (which is added in this PR). The first time that the Orion server is started after enabling the work pool feature a a default agent work pool nameddefault-agent-poolwill be created and all existing work queues will be duplicated to work pool queues in that pool. The migration will not run on subsequent server start ups.Any changes made to work queues after the initial migration will be reflected in their corresponding work pool queue.
The following actions will produce corresponding changes in a work pool queue:
As part of this PR
work_pool_queue_nameis removed from the deployments API and the existingwork_queue_namewill be used instead.Additionally, any work queue that is created without a work pool will trigger the creation of the default agent work pool if it does not already exist.
Example
Checklist
<link to issue>"fix,feature,enhancement