Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes agents work pool aware #8222

Merged
merged 10 commits into from
Jan 23, 2023
Merged

Makes agents work pool aware #8222

merged 10 commits into from
Jan 23, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 20, 2023

Adds the option to specify a work pool when starting an agent. The normally functionality is left untouched.

The following functionality is added:

  • If a work pool is specified with a queue or a queue prefix, the agent will poll for runs from the matching queues under the specified work pool.
  • If only a work pool is provided, the agent will poll for runs from all queues in that work pool.

Example

Start an agent to poll from a specific queues in a work pool:

prefect agent start --pool test-pool --queue test-queue-1 --queue test-queue-2

Start an agent to poll from a queues in a work pool:

prefect agent start --pool test-pool

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@desertaxle desertaxle force-pushed the agent-work-pool-compatibility branch from 84d6ab6 to 6e1f124 Compare January 21, 2023 01:53
@desertaxle desertaxle changed the base branch from work-pool-deployments-refactor to main January 21, 2023 01:54
@netlify
Copy link

netlify bot commented Jan 21, 2023

Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 9f3bebd
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63ced6e0c19bef0009163296
😎 Deploy Preview https://deploy-preview-8222--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@desertaxle desertaxle changed the title WIP: Makes agents work pool aware Makes agents work pool aware Jan 21, 2023
@desertaxle desertaxle marked this pull request as ready for review January 21, 2023 19:15
@desertaxle desertaxle requested review from a team and zangell44 as code owners January 21, 2023 19:15
@desertaxle desertaxle requested a review from cicdw January 21, 2023 19:15
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few suggestions in-code here

@desertaxle desertaxle requested a review from pleek91 as a code owner January 22, 2023 21:53
Copy link
Contributor

@pleek91 pleek91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI changes look good to me 👍

Copy link
Contributor

@peytonrunyan peytonrunyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@desertaxle desertaxle merged commit 1d674f2 into main Jan 23, 2023
@desertaxle desertaxle deleted the agent-work-pool-compatibility branch January 23, 2023 19:38
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
Co-authored-by: Chris White <chris@prefect.io>
github-actions bot pushed a commit that referenced this pull request Jan 26, 2023
Co-authored-by: Chris White <chris@prefect.io>
zanieb pushed a commit that referenced this pull request Feb 6, 2023
Co-authored-by: Chris White <chris@prefect.io>
zanieb pushed a commit that referenced this pull request Feb 6, 2023
Co-authored-by: Chris White <chris@prefect.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants