Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work queue data migration #8327

Merged
merged 8 commits into from
Feb 1, 2023
Merged

Work queue data migration #8327

merged 8 commits into from
Feb 1, 2023

Conversation

desertaxle
Copy link
Member

@desertaxle desertaxle commented Jan 31, 2023 •
edited
Loading

Adds data migration to create a default agent work pool and migrate all work queues to that work pool. Also updates work_queue_id column on flow_run and deployment tables to enable work pool polling.

Example

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement

@desertaxle desertaxle force-pushed the work-queue-data-migration branch from 7bd182f to cd5b427 Compare January 31, 2023 19:18
@desertaxle desertaxle mentioned this pull request Jan 31, 2023
Merged
@desertaxle desertaxle force-pushed the work-queue-data-migration branch from cd5b427 to bde230b Compare January 31, 2023 20:01
anticorrelator
anticorrelator reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@anticorrelator anticorrelator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data migration looks good, we should make sure that all of the join conditions for our loops are indexed before merging this

...e/migrations/versions/postgresql/2023_01_31_110543_f98ae6d8e2cc_work_queue_data_migration.py Show resolved Hide resolved
@desertaxle desertaxle force-pushed the work-queue-data-migration branch from f42496b to c117084 Compare February 1, 2023 01:41
Base automatically changed from bye-wpqs-wink-wink to main February 1, 2023 02:36
@desertaxle desertaxle force-pushed the work-queue-data-migration branch from c117084 to 4f7a273 Compare February 1, 2023 02:45
@netlify
Copy link

netlify bot commented Feb 1, 2023 •
edited
Loading

✅ Deploy Preview for prefect-orion ready!

Name Link
🔨 Latest commit 54e6e44
🔍 Latest deploy log https://app.netlify.com/sites/prefect-orion/deploys/63da7e09c9d57d00086ed70e
😎 Deploy Preview https://deploy-preview-8327--prefect-orion.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@desertaxle desertaxle marked this pull request as ready for review February 1, 2023 15:32
@desertaxle desertaxle requested review from a team and zangell44 as code owners February 1, 2023 15:32
@desertaxle desertaxle changed the title WIP: Work queue data migration Work queue data migration Feb 1, 2023
anticorrelator
anticorrelator approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@anticorrelator anticorrelator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data migration looks good to me

@desertaxle desertaxle merged commit 4da112e into main Feb 1, 2023
@desertaxle desertaxle deleted the work-queue-data-migration branch February 1, 2023 16:45
@zanieb zanieb mentioned this pull request Feb 3, 2023
Merged
3 tasks
zanieb pushed a commit that referenced this pull request Feb 3, 2023
@desertaxle @zanieb
Work queue data migration (#8327)
01c2fe6
zanieb pushed a commit that referenced this pull request Feb 3, 2023
@desertaxle @zanieb
Work queue data migration (#8327)
d60339d
@zanieb zanieb mentioned this pull request Feb 6, 2023
Merged
zanieb pushed a commit that referenced this pull request Feb 6, 2023
@desertaxle @zanieb
Work queue data migration (#8327)
d41e855
zanieb pushed a commit that referenced this pull request Feb 6, 2023
@desertaxle @zanieb
Work queue data migration (#8327)
66cec2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anticorrelator anticorrelator anticorrelator approved these changes

@zangell44 zangell44 Awaiting requested review from zangell44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@desertaxle @anticorrelator