Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /artifacts/latest/count route #9090

Merged
merged 8 commits into from
Apr 7, 2023
Merged

Add /artifacts/latest/count route #9090

merged 8 commits into from
Apr 7, 2023

Conversation

serinamarie
Copy link
Contributor

@serinamarie serinamarie commented Apr 5, 2023 •
edited
Loading

Add ability to count all latest artifacts.

OSS implementation of: https://github.com/PrefectHQ/nebula/pull/4323

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • This pull request includes tests or only affects documentation.
  • This pull request includes a label categorizing the change e.g. fix, feature, enhancement, docs.

@serinamarie serinamarie marked this pull request as ready for review April 7, 2023 16:26
@serinamarie serinamarie requested review from a team and zangell44 as code owners April 7, 2023 16:26
@serinamarie serinamarie requested a review from a team April 7, 2023 16:27
jakekaplan
jakekaplan approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@jakekaplan jakekaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from add-more-artifact-filters to main April 7, 2023 16:43
@netlify
Copy link

netlify bot commented Apr 7, 2023 •
edited
Loading

✅ Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 6946462
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/64304ae7147a6500080ba133
😎 Deploy Preview https://deploy-preview-9090--prefect-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@serinamarie serinamarie merged commit 84e4eb4 into main Apr 7, 2023
@serinamarie serinamarie deleted the add-count-latest-route branch April 7, 2023 18:34
asmundo pushed a commit to asmundo/prefect that referenced this pull request May 11, 2023
@serinamarie
Add /artifacts/latest/count route (PrefectHQ#9090)
e360a9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakekaplan jakekaplan jakekaplan approved these changes

@zangell44 zangell44 Awaiting requested review from zangell44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serinamarie @jakekaplan