Rename __root_path__ to __development_base_path__
#9136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To clarify that this path is not available in production installs (i.e. non-editable)
✅ Deploy Preview for prefect-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
zanieb
commented
Apr 7, 2023
| @@ -33,7 +34,7 @@ async def ls(): | |||
| List available recipes. | |||
| """ | |||
|
|
|||
| recipe_paths = Path(__file__).parent / ".." / "projects" / "recipes" | |||
| recipe_paths = prefect.__module_path__ / "projects" / "recipes" | |||
There was a problem hiding this comment.
I don't have strong feelings about this change but it's consistent with the purpose of having the module path in the init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To clarify that this path is not available in production installs (i.e. non-editable) to avoid future problems like #9132 — this has bit me before as well.