Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide command when access token is provided and git_clone_project fails #9150

Merged
merged 3 commits into from
Apr 11, 2023

Conversation

zanieb
Copy link
Contributor

@zanieb zanieb commented Apr 7, 2023

Hides the called process error displaying the used command when an access token is provided since the access token is in the command.

@zanieb zanieb added the fix A fix for a bug in an existing feature label Apr 7, 2023
@netlify
Copy link

netlify bot commented Apr 7, 2023

Deploy Preview for prefect-docs-preview ready!

Name Link
🔨 Latest commit 9dcbf28
🔍 Latest deploy log https://app.netlify.com/sites/prefect-docs-preview/deploys/6435995b6433ed0008241c3f
😎 Deploy Preview https://deploy-preview-9150--prefect-docs-preview.netlify.app/api-ref/prefect/projects/steps/pull
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@cicdw
Copy link
Member

cicdw commented Apr 7, 2023

Probably worth merging with the steaming output implementation in #9149

@zanieb
Copy link
Contributor Author

zanieb commented Apr 7, 2023

@cicdw I figure I'll just resolve the merge conflict after that one is merged then add tests here.

@zanieb zanieb force-pushed the hide-access-token branch from b2144ec to cc3276e Compare April 7, 2023 18:59
@cicdw cicdw marked this pull request as ready for review April 11, 2023 17:31
@cicdw cicdw requested a review from a team as a code owner April 11, 2023 17:31
@cicdw cicdw requested review from desertaxle and removed request for a team April 11, 2023 17:31
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanieb
Copy link
Contributor Author

zanieb commented Apr 11, 2023

Thanks Chris!

@cicdw cicdw merged commit 93bedef into main Apr 11, 2023
@cicdw cicdw deleted the hide-access-token branch April 11, 2023 18:27
asmundo pushed a commit to asmundo/prefect that referenced this pull request May 11, 2023
…ils (PrefectHQ#9150)

Co-authored-by: Chris White <chris@prefect.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug in an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants