Scatter plot #5
Merged
Scatter plot #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pleek91
requested changes
Apr 12, 2022
src/ScatterPlot.vue
Outdated
| <div | ||
| :style="calculateDotPosition(item)" | ||
| class="scatter-plot__dot" | ||
| :class="item.class?.toLowerCase()" |
There was a problem hiding this comment.
toLowerCase() is unnecessary and unexpected IMO. Let's just bind whatever is passed in. Plus side that means we won't have a ? in the template.
There was a problem hiding this comment.
I have a comment on this below but it might make more sense to provide a slot instead, which can be classed accordingly, instead of requiring markup/styling info to be passed with data
There was a problem hiding this comment.
Agreed. If we do that though I'd want to make a way so if you use the slot you can "inherit" to dot from the chart. That way if all you want to do is add a class you can do so without recreating the dot
pleek91
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.