Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Review useRouteQueryParam format.set() #333

Closed
zhen0 opened this issue Oct 26, 2023 · 2 comments
Closed

Bug: Review useRouteQueryParam format.set() #333

zhen0 opened this issue Oct 26, 2023 · 2 comments

Comments

@zhen0
Copy link
Member

zhen0 commented Oct 26, 2023

As discussed in #332, format.set(query, value) in useRouteQueryParam is triggering updates in more than the query which is causing reactive affects to trigger multiple times. We fixed this with a bandaid in #332 so the impact is smaller but in slower time we shoudl dig and see if we can find a route cause and fix.
@pleek91
Copy link
Collaborator

pleek91 commented Nov 9, 2023

This should be fixed by vuejs/core#5912

@pleek91
Copy link
Collaborator

pleek91 commented Nov 15, 2023

Closed by #345

@pleek91 pleek91 closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pleek91 @zhen0