Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
useRouteQuery
works by creating an array of operations to apply to the query and then updating the query in batches. But when the operations were flushed to the actual route the operations were being cleared before updating the route. This resulted in individual query params flipping from the new value to the old value and then back to the new value.Reproduction
Result
Expected
Fix
Waiting to clear the operations from the queue until after they have been applied to the route fixes the issue.
Thank you @collincchoy for the reproduction and debugging you did on #332 which was a bandaid fix that we ultimately reverted because it caused other issues.