[useValidation] Add support for getters for value in useValidation. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collincchoy
commented
Apr 2, 2024
| export function useValidation<T>( | ||
| value: MaybeRef<T>, | ||
| value: MaybeRefOrGetter<T>, | ||
| nameOrRules: MaybeRef<string> | RulesArg<NoInfer<T>>, |
There was a problem hiding this comment.
I looked into trying to make name be passable via a getter as well, but it gets more complicated trying to distinguish between a rule (which can be a function) and a getter.
There was a problem hiding this comment.
yeah probably not worth it right now.
pleek91
approved these changes
Apr 2, 2024
| @@ -77,7 +77,7 @@ export function useValidation<T>( | |||
| throw new Error('Invalid useValidation arguments') | |||
| } | |||
|
|
|||
| const valueRef = ref(value) as Ref<T> | |||
| const valueRef = toRef(value) | |||
There was a problem hiding this comment.
ayyy nice got rid of an as
| export function useValidation<T>( | ||
| value: MaybeRef<T>, | ||
| value: MaybeRefOrGetter<T>, | ||
| nameOrRules: MaybeRef<string> | RulesArg<NoInfer<T>>, |
There was a problem hiding this comment.
yeah probably not worth it right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.