Updated Crawler.java

PreferredAI · Sep 1, 2020 · 6cb6ade · 6cb6ade
1 parent db2ac43
commit 6cb6ade
Showing 1 changed file with 50 additions and 24 deletions.
diff --git a/src/main/java/ai/preferred/venom/Crawler.java b/src/main/java/ai/preferred/venom/Crawler.java
@@ -351,30 +351,7 @@ private void run() {
                 }
               });
 
-          final Callback callback = new Callback() {
-            @Override
-            public void completed(final @NotNull Request request, final @NotNull Response response) {
-              LOGGER.debug("Completed received for job {} - {}.", Integer.toHexString(job.hashCode()),
-                  job.getRequest().getUrl());
-              completableResponseFuture.complete(response);
-            }
-
-            @Override
-            public void failed(final @NotNull Request request, final @NotNull Exception ex) {
-              LOGGER.debug("Failed received for job {} - {}.", Integer.toHexString(job.hashCode()),
-                  job.getRequest().getUrl());
-              completableResponseFuture.completeExceptionally(ex);
-            }
-
-            @Override
-            public void cancelled(final @NotNull Request request) {
-              LOGGER.debug("Cancelled received for job {} - {}.", Integer.toHexString(job.hashCode()),
-                  job.getRequest().getUrl());
-              completableResponseFuture.cancel(true);
-            }
-          };
-
-          fetcher.fetch(crawlerRequest, callback);
+          fetcher.fetch(crawlerRequest, new CompletableCallback(job, completableResponseFuture));
         });
       } catch (final InterruptedException e) {
         LOGGER.debug("({}) producer thread interrupted.", crawlerThread.getName(), e);
@@ -517,6 +494,55 @@ public void close() throws Exception {
     }
   }
 
+  /**
+   * A callback that utilises CompletableFuture.
+   */
+  private static final class CompletableCallback implements Callback {
+
+    /**
+     * The job this callback is for.
+     */
+    private final Job job;
+
+    /**
+     * The CompletableFuture to call upon response.
+     */
+    private final CompletableFuture<Response> completableResponseFuture;
+
+    /**
+     * Constructs an instance of CompletableCallback.
+     *
+     * @param job                       The job this callback is for.
+     * @param completableResponseFuture The CompletableFuture to call upon response.
+     */
+    private CompletableCallback(final Job job, final CompletableFuture<Response> completableResponseFuture) {
+      this.job = job;
+      this.completableResponseFuture = completableResponseFuture;
+    }
+
+    @Override
+    public void completed(final @NotNull Request request, final @NotNull Response response) {
+      LOGGER.debug("Completed received for job {} - {}.", Integer.toHexString(job.hashCode()),
+          job.getRequest().getUrl());
+      completableResponseFuture.complete(response);
+    }
+
+    @Override
+    public void failed(final @NotNull Request request, final @NotNull Exception ex) {
+      LOGGER.debug("Failed received for job {} - {}.", Integer.toHexString(job.hashCode()),
+          job.getRequest().getUrl());
+      completableResponseFuture.completeExceptionally(ex);
+    }
+
+    @Override
+    public void cancelled(final @NotNull Request request) {
+      LOGGER.debug("Cancelled received for job {} - {}.", Integer.toHexString(job.hashCode()),
+          job.getRequest().getUrl());
+      completableResponseFuture.cancel(true);
+    }
+
+  }
+
   /**
    * A builder for crawler class.
    */