Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README with instructions for new containers #1

Merged
merged 5 commits into from
Oct 25, 2024
Merged

Update README with instructions for new containers #1

merged 5 commits into from
Oct 25, 2024

Conversation

cwschilly
Copy link
Collaborator

@cwschilly cwschilly commented Oct 15, 2024 •
edited
Loading

This PR adds instructions to the README for adding new containers to the github container registry (https://github.com/orgs/Pressio/packages).

@cwschilly cwschilly self-assigned this Oct 16, 2024
@cwschilly cwschilly requested a review from fnrizzi October 16, 2024 16:23
@cwschilly cwschilly changed the title Test new containers Update README with instructions for new containers Oct 16, 2024
fnrizzi
fnrizzi requested changes Oct 17, 2024
View reviewed changes
Copy link
Member

@fnrizzi fnrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please also add a couple sentences to explain that the repo also contains the workflow that gets run in the ci and the container is pushed , etc
    otherwise one might think this is just a container of docker files.

@cwschilly cwschilly requested a review from fnrizzi October 24, 2024 12:51
@fnrizzi fnrizzi merged commit c687d08 into main Oct 25, 2024
@fnrizzi fnrizzi deleted the investigate-new-containers branch October 25, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnrizzi fnrizzi fnrizzi approved these changes

Assignees

@cwschilly cwschilly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cwschilly @fnrizzi