update trilinos container tags #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwschilly
force-pushed
the
update-trilinos-containers
branch
from
5307253 to
c0aa7ff
Compare
cwschilly
force-pushed
the
update-trilinos-containers
branch
from
c53f44e to
e3a278f
Compare
cwschilly
commented
Dec 12, 2024
| #ifdef PRESSIO_ENABLE_TPL_EPETRA | ||
| #ifdef PRESSIO_ENABLE_EPETRA |
There was a problem hiding this comment.
This is the actual fix for the CI failures
cwschilly
commented
Dec 12, 2024
| @@ -67,7 +66,7 @@ jobs: | |||
| -D EIGEN_INCLUDE_DIR=/eigen/eigen-${{ env.eigen_version }} \ | |||
| -D Trilinos_DIR=${{ env.trilinos_dir }}/lib/cmake/Trilinos \ | |||
| -D CMAKE_INSTALL_PREFIX:PATH=../install \ | |||
| -D CMAKE_CXX_FLAGS='-Wall -Werror' | |||
There was a problem hiding this comment.
This is necessary because Trilinos has deprecated Epetra, resulting in a bunch of warnings:
#warning "The Epetra package is deprecated"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds tests for Epetra (these were not ported over from Pressio/pressio)