-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change feature value table to add position field #925
Conversation
ks129
commented
Sep 27, 2024
Questions | Answers |
---|---|
Description? | Added position field to feature value table in 9.0.0. Part of PrestaShop/PrestaShop#37042 |
Type? | new feature |
BC breaks? | no |
Deprecations? | no |
Fixed ticket? | part of PrestaShop/PrestaShop#35499 and PrestaShop/PrestaShop#32267 |
Sponsor company | - |
How to test? | After upgrading to 9.0.0, feature value table should have position field. |
Hello @ks129! This is your first pull request on autoupgrade repository of the PrestaShop project. Thank you, and welcome to this Open Source community! |
Thank you for your contribution! I have blocked the PR while the PR relating to it is merged on the Core. Do not hesitate to ping me if it is merged and I have not reacted in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you. Labeling as "Blocked" until the PR is merged on PrestaShop repository.
831f1ce
to
aeaf9dc
Compare
function ps_900_update_configuration() | ||
{ | ||
Configuration::updateValue('PS_FEATURE_VALUES_ORDER', 'name'); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method does not seem called by the 9.0.0.sql script.
If you want to add configuration values to the shop, you may refer to this other SQL query:
autoupgrade/upgrade/sql/9.0.0.sql
Lines 58 to 60 in e165864
/* Allow cover configuration */ | |
/* https://github.com/PrestaShop/PrestaShop/pull/33363 */ | |
INSERT INTO `PREFIX_configuration` (`name`, `value`, `date_add`, `date_upd`) VALUES ('PS_USE_COMBINATION_IMAGE_IN_LISTING', '0', NOW(), NOW()); |
c0f1ec9
to
c75373c
Compare
|
Hi @ks129, |
@Quetzacoalt91 I already rebased it today. |
Indeed! Sorry for that, I checked the backlog of PRs yesterday and only remembered this morning that I did not post here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ks129
Thank you for your PR, I tested it and it seems to works as you can see :
Tested from :
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
Thanks @ks129 |
PR merged, well done! Message to @PrestaShop/committers: do not forget to milestone it before the merge. |