-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new and obsolete hooks for 9.0.0 #957
Conversation
4d0e808
to
fb610c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The query is missing ON DUPLICATE KEY UPDATE `title` = VALUES(`title`), `description` = VALUES(`description`);
(This was added by my PR to update automatically-added hooks that would now be without description.)
@Hlavtox you're right I integrated it in the command later, but I must have updated this PR improperly |
fb610c4
to
8028a43
Compare
@Hlavtox @Quetzacoalt91 this should be good now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jolelievre 👍
Incoming conflict with #981 |
8028a43
to
e7581cc
Compare
|
Thanks @Quetzacoalt91 it's fixed, it would be great if this one can be validated soon to avoid any other conflicts because it is blocking the core PR that generates this automatically PrestaShop/PrestaShop#37168 Once the new command is merged we'll update the release process so that it is included in the steps to do by the core team, this means people won't need to create update hooks PR because we can semi-automatically handle all of them as long as the One possible improvement of the CLI command would be to update an already existing SQL query for hooks, but this will be done in some other PR if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jolelievre
Thank you for your PR, I tested it and it seems to works.
Tested from :
8.0.4 to 8.2
8.2 to 9.0.0
8.0.4 to 9.0.0
Because the PR seems to works as expected, It's QA ✔️
Thank you
This PR was auto-generated thanks to the core Symfony command, which was improved in this PR PrestaShop/PrestaShop#37168