Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt theme for new presenter system #117

Merged
merged 3 commits into from
Jun 19, 2023
Merged

Adapt theme for new presenter system #117

merged 3 commits into from
Jun 19, 2023

Conversation

Hlavtox
Copy link
Contributor

@Hlavtox Hlavtox commented May 20, 2023

Questions Answers
Description? Makes use of the new presenters feeding data to FO, allows use of multiple image formats. This PR is required for this to work - PrestaShop/PrestaShop#32634
Type? new feature
BC breaks? yes
Deprecations? no
Fixed ticket?
Sponsor company
How to test? Install PrestaShop/PrestaShop#32634, install this, check that it behaves the same.

@Hlavtox Hlavtox mentioned this pull request May 20, 2023
Merged
@Hlavtox Hlavtox mentioned this pull request May 22, 2023
Merged
tleon
tleon approved these changes May 23, 2023
View reviewed changes
Copy link

@tleon tleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hlavtox @M0rgan01
Update templates/catalog/manufacturers.tpl
ef48a2b 
Co-authored-by: Morgan Pichat <36233446+M0rgan01@users.noreply.github.com>
@Hlavtox
Copy link
Contributor Author

Hlavtox commented May 30, 2023

@M0rgan01 @tleon Fixed. :-)

@kpodemski kpodemski added the Blocked Status: The issue is blocked by another task label Jun 8, 2023
@hibatallahAouadni hibatallahAouadni added Waiting for QA Status: Waiting for QA feedback and removed Blocked Status: The issue is blocked by another task labels Jun 19, 2023
@florine2623 florine2623 self-assigned this Jun 19, 2023
florine2623
florine2623 approved these changes Jun 19, 2023
View reviewed changes
Copy link

@florine2623 florine2623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hlavtox ,

Tested with PrestaShop/PrestaShop#32634

Screen.Recording.2023-06-19.at.17.45.16.mov

LGTM. It is QA ✅ !
Thanks!

@florine2623 florine2623 added QA ✔️ Status: QA-Approved and removed Waiting for QA Status: Waiting for QA feedback labels Jun 19, 2023
@nicosomb nicosomb merged commit c025904 into PrestaShop:develop Jun 19, 2023
@nicosomb nicosomb added this to the 2.1.2 milestone Jun 19, 2023
@nicosomb
Copy link
Contributor

Thank you @Hlavtox !

@Hlavtox Hlavtox modified the milestones: 2.1.2, 3.0.0 Jul 10, 2023
@Hlavtox Hlavtox mentioned this pull request Jul 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M0rgan01 M0rgan01 M0rgan01 approved these changes

@florine2623 florine2623 florine2623 approved these changes

@tleon tleon tleon approved these changes

@kpodemski kpodemski kpodemski approved these changes

Assignees

@florine2623 florine2623

Labels
QA ✔️ Status: QA-Approved
Projects
PR Dashboard
Archived in project
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Hlavtox @nicosomb @kpodemski @tleon @florine2623 @M0rgan01 @hibatallahAouadni