Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define missing hooks in list #1463

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Define missing hooks in list #1463

merged 4 commits into from
Sep 2, 2022

Conversation

zuk3975
Copy link
Contributor

@zuk3975 zuk3975 commented Aug 23, 2022

Questions Answers
Branch? 8.x
Description? Couldn't find where hook displayCheckoutBeforeConfirmation is executed, only found it defined in hook.xml
Fixed ticket? #1447

@zuk3975
Copy link
Contributor Author

zuk3975 commented Aug 23, 2022

Notes:

  • actionGetAdminToolbarButtons - unnecessary & in params. That is a collection object, so im pretty sure ampersand is useless here.
  • it would be nice to use psalm notations to define array structures in hook params. (probably in dedicated pr) E.g.
'previous_search_panels' => (SearchPanelInterface[]) $searchPanels,

or

'previous_search_panels' => (array<int, SearchPanelInterface>) $searchPanels,

@github-actions github-actions bot added the 8.x label Aug 23, 2022
@zuk3975 zuk3975 mentioned this pull request Aug 23, 2022
Closed
PrestaEdit
PrestaEdit reviewed Aug 23, 2022
View reviewed changes
modules/concepts/hooks/list-of-hooks.md Outdated

actionOrderStatusUpdate
:
Available since: {{< minver v="8.0.0" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Available since: {{< minver v="8.0.0" >}}
Available since: {{< minver v="1.5.5" >}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this hook was defined correctly in docs already. Removed my change. 👍

PrestaEdit
PrestaEdit reviewed Aug 23, 2022
View reviewed changes
modules/concepts/hooks/list-of-hooks.md Outdated

actionOrderStatusPostUpdate
:
Available since: {{< minver v="8.0.0" >}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Available since: {{< minver v="8.0.0" >}}
Available since: {{< minver v="1.5.5" >}}

Copy link
Contributor Author

@zuk3975 zuk3975 Aug 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same with this one - duplicate. Removed my change.

yanmakouf
yanmakouf approved these changes Aug 26, 2022
View reviewed changes
Copy link

@yanmakouf yanmakouf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@matks
Copy link
Contributor

matks commented Sep 2, 2022

Thank you @zuk3975

@matks matks merged commit 99678bc into PrestaShop:8.x Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrestaEdit PrestaEdit PrestaEdit left review comments

@yanmakouf yanmakouf yanmakouf approved these changes

@matks matks matks approved these changes

@matthieu-rolland matthieu-rolland matthieu-rolland approved these changes

Assignees
No one assigned
Labels
8.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zuk3975 @matks @matthieu-rolland @PrestaEdit @yanmakouf