Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product reference only shown if manufacturer is set #569

Closed
tswfi opened this issue Dec 19, 2023 · 0 comments · Fixed by #570
Closed

Product reference only shown if manufacturer is set #569

tswfi opened this issue Dec 19, 2023 · 0 comments · Fixed by #570

Comments

@tswfi
Copy link
Contributor

tswfi commented Dec 19, 2023

If product does not have manufacturer set the product reference wont be shown.

See here: https://github.com/PrestaShop/hummingbird/blob/develop/templates/catalog/_partials/product-details.tpl#L17

Also the block naming is kinda misleading as the block is named product_reference but it contains both manufacturer and reference information.

Also would be really nice to have specific class for each detail li element. Maybe the detail__title information could be used to generate class for the li (does smarty have a slugify formatter)? That would allow doing things like highlighting one specific detail with just css.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant