Fix: Separate product reference and manufacturer #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dennispw
commented
Dec 19, 2023
dennispw
commented
| Questions | Answers |
|---|---|
| Description? | Separates product reference and manufacturer information to different blocks and if statements. |
| Type? | bug fix |
| BC breaks? | no |
| Deprecations? | no |
| Fixed ticket? | Fixes #569 |
SharakPL
reviewed
Jan 2, 2024
Co-authored-by: Tom Zajac <SharakPL@users.noreply.github.com>
boherm
approved these changes
Jan 3, 2024
florine2623
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Hello @tswfi ,
Tested with all types of products. LGTM
Tested with/out supplier, with/out supplier ref, with/out combination ref.
Screen.Recording.2024-01-04.at.10.50.48.mov
Thanks!
|
Thanks @dennispw and @florine2623 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.