-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multiple slider update on facetsearch #550
Conversation
tblivet
commented
Sep 28, 2023
Questions | Answers |
---|---|
Description? | Fix an issue when multiple sliders are presents on faceted search ( the price and product weight who show in slider mode ) |
Type? | bug fix |
BC breaks? | no |
Deprecations? | |
Fixed ticket? | This fix is related to this previous fix 81e8204 |
Sponsor company | @PrestaShopCorp |
How to test? | You have to add some weight on few products for example one with 1kg another with 2kg and another with 3kg after that you can go to ps_facetedsearch configuration module click on "Reconstruire l'index intégralement" after that you can access in FO the category that contains the products with different weights and check if the price and weight filter work well :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm too, thanks @tblivet!
Hello @tblivet , When I install the PR, I can't choose "Use this theme" option. I'm having this issue : |
Hello @florine2623, |
Here's the command that I used :
The PR is well installed, the theme is well installed. But when I try to apply it to my shop, I'm having an error. Screen.Recording.2023-10-13.at.16.31.28.mov |
There is no |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tblivet ,
Sorry for the delay in the answer .
I tested it. Works as expected. LGTM.
Screen.Recording.2024-01-04.at.11.46.39.mov
In my case, I didn't need to rebuild the entire index. I didn't change anything and worked in both cases.
Thanks!