Merge pull request #45 from boherm/fix-welcoming-himself

PrestaShop · Jun 10, 2024 · 2e2536c · 2e2536c
2 parents e484f5c + b885255
commit 2e2536c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/src/PullRequest/Application/CommandHandler/WelcomeNewContributorCommandHandler.php b/src/PullRequest/Application/CommandHandler/WelcomeNewContributorCommandHandler.php
@@ -11,6 +11,11 @@
 
 class WelcomeNewContributorCommandHandler
 {
+    public const EXCLUDED_CONTRIBUTORS = [
+        'dependabot[bot]',
+        'ps-jarvis',
+    ];
+
     public function __construct(
         private readonly CommitterRepositoryInterface $committerRepository,
         private readonly PullRequestRepositoryInterface $prRepository
@@ -20,7 +25,7 @@ public function __construct(
     public function __invoke(WelcomeNewContributorCommand $command): void
     {
         // We ignore dependabot PRs.
-        if ('dependabot[bot]' === $command->contributor) {
+        if (in_array($command->contributor, self::EXCLUDED_CONTRIBUTORS)) {
             return;
         }
 

diff --git a/tests/PullRequest/Application/CommandHandler/WelcomeNewContributorCommandHandlerTest.php b/tests/PullRequest/Application/CommandHandler/WelcomeNewContributorCommandHandlerTest.php
@@ -120,6 +120,16 @@ public static function provideTestHandle(): array
                 true,
                 false,
             ],
+            [
+                new PullRequestId(
+                    repositoryOwner: 'PrestaShop',
+                    repositoryName: 'PrestaShop',
+                    pullRequestNumber: 'pullRequestNumber'
+                ),
+                'ps-jarvis',
+                true,
+                false,
+            ],
         ];
     }
 }