Merge pull request #49 from boherm/improve-check-table-description

Improve check table description
PrestaShop · Jun 14, 2024 · 6985a2f · 6985a2f
2 parents 3d6d91f + 125640b
commit 6985a2f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 2 deletions.
diff --git a/src/PullRequest/Domain/Aggregate/PullRequest/PullRequestDescription.php b/src/PullRequest/Domain/Aggregate/PullRequest/PullRequestDescription.php
@@ -143,8 +143,8 @@ public function getSponsor(): ?string
 
     public function isLinkedIssuesNeeded(): bool
     {
-        // If "n/a" is found, it means that the PR doesn't need an issue anyway.
-        if ('n/a' === $this->extractWithRegex('Fixed issue or discussion')) {
+        // If "n/a" or "~" is found, it means that the PR doesn't need an issue anyway.
+        if (in_array(strtolower($this->extractWithRegex('Fixed issue or discussion')), ['n/a', '~'])) {
             return false;
         }
 

diff --git a/tests/PullRequest/Application/CommandHandler/CheckTableDescriptionCommandHandlerTest.php b/tests/PullRequest/Application/CommandHandler/CheckTableDescriptionCommandHandlerTest.php
@@ -642,6 +642,23 @@ public static function provideTestHandle(): array
                 true,
                 ['Feature'],
             ],
+            [
+                new PullRequestId(
+                    repositoryOwner: 'PrestaShop',
+                    repositoryName: 'PrestaShop',
+                    pullRequestNumber: 'fake'
+                ),
+                '
+                | Type?                          | new feature
+                | Category?                      | BO
+                | Fixed issue or discussion?     | ~
+                ',
+                [],
+                [],
+                false,
+                true,
+                ['Feature'],
+            ],
             [
                 new PullRequestId(
                     repositoryOwner: 'PrestaShop',