Merge pull request #47 from boherm/improve-check-table-command

PrestaShop · Jun 11, 2024 · cd7385d · cd7385d
2 parents 1f01408 + 4e6653e
commit cd7385d
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/src/PullRequest/Domain/Aggregate/PullRequest/PullRequestDescription.php b/src/PullRequest/Domain/Aggregate/PullRequest/PullRequestDescription.php
@@ -143,6 +143,11 @@ public function getSponsor(): ?string
 
     public function isLinkedIssuesNeeded(): bool
     {
+        // If "n/a" is found, it means that the PR doesn't need an issue anyway.
+        if ('n/a' === $this->extractWithRegex('Fixed issue or discussion')) {
+            return false;
+        }
+
         return in_array($this->getType(), ['bug fix', 'new feature']) && !in_array($this->getCategory(), ['TE', 'ME', 'PM']);
     }
 

diff --git a/tests/PullRequest/Application/CommandHandler/CheckTableDescriptionCommandHandlerTest.php b/tests/PullRequest/Application/CommandHandler/CheckTableDescriptionCommandHandlerTest.php
@@ -625,6 +625,23 @@ public static function provideTestHandle(): array
                 true,
                 ['Feature'],
             ],
+            [
+                new PullRequestId(
+                    repositoryOwner: 'PrestaShop',
+                    repositoryName: 'PrestaShop',
+                    pullRequestNumber: 'fake'
+                ),
+                '
+                | Type?                          | new feature
+                | Category?                      | BO
+                | Fixed issue or discussion?     | n/a
+                ',
+                [],
+                [],
+                false,
+                true,
+                ['Feature'],
+            ],
             [
                 new PullRequestId(
                     repositoryOwner: 'PrestaShop',