-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some authentication related checks #111
Open
jonbarrow
wants to merge
13
commits into
dev
Choose a base branch
from
auth-updates
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+14,353
−14,173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniElectra
reviewed
Oct 29, 2024
@@ -137,7 +146,7 @@ class NintendoCertificate { | |||
this.consoleType = '3ds'; | |||
} | |||
|
|||
this._verifySignature(); | |||
this._verifySignatureECDSA(); // * Force it to use the expected certificate type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this changed?
This reflects the hot patches on the account server. A couple things:
diff --git a/src/services/nasc/routes/ac.ts b/src/services/nasc/routes/ac.ts
index 1a8c616..d126ed9 100644
--- a/src/services/nasc/routes/ac.ts
+++ b/src/services/nasc/routes/ac.ts
@@ -40,7 +40,7 @@ router.post('/', async (request: express.Request, response: express.Response): P
if (server.maintenance_mode) {
// TODO - FIND THE REAL UNDER MAINTENANCE ERROR CODE. 110 IS NOT IT
- response.status(200).send(nascError('110').toString());
+ response.status(503).send(nascError('101').toString());
return;
}
@@ -112,4 +112,4 @@ async function processServiceTokenRequest(server: HydratedServerDocument, pid: n
});
}
-export default router;
\ No newline at end of file
+export default router; |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #XXX
Changes:
These changes have been hot-patched in the prod servers for a long time now. This PR simply brings them upstream. Changes include:
Basic
auth in some endpointsMarking as draft for now since I hate the way the "check the system type" feature was implemented. It's a hack, and I want to change it. There's also a couple open issues now directly relating to tokens which we may want to implement here first before merging? Unsure, would like some opinions.
[Enhancement]: Store tokens in database #107
[Enhancement]: Make (some) tokens use asymmetric cryptography rather than symmetric cryptography #108
I have read and agreed to the Code of Conduct.
I have read and complied with the contributing guidelines.
What I'm implementing was an approved issue.
I have tested all of my changes.