Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker + CI #43

Merged
merged 5 commits into from
Aug 18, 2024
Merged

Add docker + CI #43

merged 5 commits into from
Aug 18, 2024

Conversation

mrjvs
Copy link
Contributor

@mrjvs mrjvs commented Aug 18, 2024

changes:

  • update dockerfile with the standardized dockerfile by matthew
  • Added CI that builds docker and pushes the image to the container registry
  • Fix npm build scripts - it just didnt work
  • Added a config.ts that parses the config.json file, so it doesnt require it to be present at compile time.

src/config.ts Outdated
Comment on lines 4 to 13
interface Config {
bot_token: string;
json_db_path: string;
sequelize: {
force: boolean;
alter: boolean;
}
}

const rawConfigData = readFileSync(path.join(process.cwd(), './config.json'), { encoding: 'utf-8' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces -> tabs and a small styling change just to keep it inline with the rest of the codebase

Suggested change
interface Config {
bot_token: string;
json_db_path: string;
sequelize: {
force: boolean;
alter: boolean;
}
}
const rawConfigData = readFileSync(path.join(process.cwd(), './config.json'), { encoding: 'utf-8' });
interface Config {
bot_token: string;
json_db_path: string;
sequelize: {
force: boolean;
alter: boolean;
}
}
const rawConfigData = readFileSync(path.join(process.cwd(), './config.json'), {
encoding: 'utf-8'
});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit, I thought it had an editorconfig so I didnt pay attention to it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That took care of the spaces but not the rawConfigData formatting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, didnt notice that changed as well, fixed (I hope?)

@jonbarrow
Copy link
Member

LGTM

@jonbarrow jonbarrow merged commit dc6d0b7 into PretendoNetwork:dev Aug 18, 2024
1 check passed
@mrjvs mrjvs deleted the feat/docker branch August 18, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants