Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to v2 libraries and small bug fixes and refactors #10

Open
wants to merge 56 commits into
base: dev
Choose a base branch
from

Conversation

jonbarrow
Copy link
Member

Draft since lots of things are changing still, but wanted to get this into more peoples hands

PR brings server up to date with the latest nex-go PR

@jonbarrow jonbarrow marked this pull request as draft November 12, 2023 11:53
@jonbarrow jonbarrow marked this pull request as ready for review April 8, 2024 12:54
@jonbarrow jonbarrow changed the base branch from master to dev April 8, 2024 12:55
@jonbarrow jonbarrow changed the title New nex-go Update to v2 libraries and small bug fixes and refactors Apr 8, 2024
@jonbarrow
Copy link
Member Author

Cemu seems to have some some DC issues, but I'm unsure if this is an us issue or a Cemu issue. Cemu would disconnect every few seconds and reconnect when in the friends applet

That said, I was connected via real hardware for around 30 minutes with no issue. Since real hardware is our main target, I'm fine with this

@DaniElectra
Copy link
Member

Are there any other Scan error checks that we would want to ignore for now?

jonbarrow and others added 30 commits April 22, 2024 16:38
The sender PID of the notification was being set to the target PID,
instead of the sender PID. Use correct PID and remove redundant target
PID argument.

Also fix minor accuracy issues.
Add Mii profanity flag and character set to the 3DS friends database.
This in theory allows better support of Mii names that use characters
exclusive to the following regions: CHN, KOR or TWN.

Also get the Mii changed timestamp from the database, and not use the
current time for it.

Update the go modules to get the latest stability updates and use the
new fields on the Mii structure.
Although the UPDATE section of the query was updated properly, the
INSERT ection was unmodified, which causes type conflicts when trying to
update the user's Mii. Update the INSERT query properly.
Initializing the server accounts in their own thread (e.g. the
authentication and secure servers) can cause a race condition where the
secure account hasn't been set up yet when authentication configures
`ticket-granting`, causing sometimes crashes on startup.

This has happened on production causing unnecesary restarts. To fix
this, initialize the accounts on the `init` function to ensure they will
always be accessible when needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants