-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to v2 libraries and small bug fixes and refactors #10
Open
jonbarrow
wants to merge
56
commits into
dev
Choose a base branch
from
nex-go-rewrite
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed comment typo in set_user_blocked.go
We can't use slices.Contains anymore since now we are comparing pointers, and the check would always return false. Replace with using the Equals function.
jonbarrow
changed the title
New nex-go
Update to v2 libraries and small bug fixes and refactors
Apr 8, 2024
Cemu seems to have some some DC issues, but I'm unsure if this is an us issue or a Cemu issue. Cemu would disconnect every few seconds and reconnect when in the friends applet That said, I was connected via real hardware for around 30 minutes with no issue. Since real hardware is our main target, I'm fine with this |
Are there any other |
The sender PID of the notification was being set to the target PID, instead of the sender PID. Use correct PID and remove redundant target PID argument. Also fix minor accuracy issues.
Add Mii profanity flag and character set to the 3DS friends database. This in theory allows better support of Mii names that use characters exclusive to the following regions: CHN, KOR or TWN. Also get the Mii changed timestamp from the database, and not use the current time for it. Update the go modules to get the latest stability updates and use the new fields on the Mii structure.
Although the UPDATE section of the query was updated properly, the INSERT ection was unmodified, which causes type conflicts when trying to update the user's Mii. Update the INSERT query properly.
Initializing the server accounts in their own thread (e.g. the authentication and secure servers) can cause a race condition where the secure account hasn't been set up yet when authentication configures `ticket-granting`, causing sometimes crashes on startup. This has happened on production causing unnecesary restarts. To fix this, initialize the accounts on the `init` function to ensure they will always be accessible when needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft since lots of things are changing still, but wanted to get this into more peoples hands
PR brings server up to date with the latest nex-go PR