Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement server side disconnect packet #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Implement server side disconnect packet #45

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7031162
Implement server side disconnect packet
PabloMK7 Apr 17, 2024
15e331d
Fix typo
PabloMK7 Apr 17, 2024
261e102
Apply suggestions
PabloMK7 Apr 17, 2024
d95a053
Use the right connection string
PabloMK7 Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions prudp_endpoint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,29 @@ func (pep *PRUDPEndPoint) processPacket(packet PRUDPPacketInterface, socket *Soc

func (pep *PRUDPEndPoint) handleAcknowledgment(packet PRUDPPacketInterface) {
connection := packet.Sender().(*PRUDPConnection)

if packet.Type() == constants.DisconnectPacket {
// * The client acknowledged a disconnect packet from the server
if connection.ConnectionState == StateDisconnecting {
// * Cleanup the connection and change state
connection.ConnectionState = StateNotConnected

slidingWindow := connection.SlidingWindow(packet.SubstreamID())
slidingWindow.ResendScheduler.AcknowledgePacket(packet.SequenceID())

streamType := packet.SourceVirtualPortStreamType()
streamID := packet.SourceVirtualPortStreamID()
discriminator := fmt.Sprintf("%s-%d-%d", packet.Sender().Address().String(), streamType, streamID)
if connection, ok := pep.Connections.Get(discriminator); ok {
connection.cleanup()
pep.Connections.Delete(discriminator)
}

pep.emit("disconnect", packet)
}
return
}

PabloMK7 marked this conversation as resolved.
Show resolved Hide resolved
if connection.ConnectionState != StateConnected {
// TODO - Log this?
// * Connection is in a bad state, drop the packet and let it die
Expand Down Expand Up @@ -641,6 +664,32 @@ func (pep *PRUDPEndPoint) sendPing(connection *PRUDPConnection) {
pep.Server.sendPacket(ping)
}

// Disconnect sends a disconnect packet to the connection. The connection
// is cleaned up once it times out or acknowledges the disconnect.
func (pep *PRUDPEndPoint) Disconnect(connection *PRUDPConnection) {
var disconnect PRUDPPacketInterface

switch connection.DefaultPRUDPVersion {
case 0:
disconnect, _ = NewPRUDPPacketV0(pep.Server, connection, nil)
case 1:
disconnect, _ = NewPRUDPPacketV1(pep.Server, connection, nil)
case 2:
disconnect, _ = NewPRUDPPacketLite(pep.Server, connection, nil)
}

disconnect.SetType(constants.DisconnectPacket)
disconnect.AddFlag(constants.PacketFlagNeedsAck)
PabloMK7 marked this conversation as resolved.
Show resolved Hide resolved
disconnect.SetSourceVirtualPortStreamType(connection.StreamType)
disconnect.SetSourceVirtualPortStreamID(pep.StreamID)
disconnect.SetDestinationVirtualPortStreamType(connection.StreamType)
disconnect.SetDestinationVirtualPortStreamID(connection.StreamID)
disconnect.SetSubstreamID(0)

connection.ConnectionState = StateDisconnecting
pep.Server.sendPacket(disconnect)
}

// FindConnectionByID returns the PRUDP client connected with the given connection ID
func (pep *PRUDPEndPoint) FindConnectionByID(connectedID uint32) *PRUDPConnection {
var connection *PRUDPConnection
Expand Down