Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Log progress/status to Prime Intellect PRI-442 #28

Closed
wants to merge 1 commit into from

Conversation

manveerxyz
Copy link

@manveerxyz manveerxyz commented Sep 10, 2024

  • Setup a status/progress logger and integrate it so that we can visualize training progress on Prime Intellect
  • Needed to log node information as well as the data we push to w&b

TODO:
[ ] Treat this as a library by adding a flag to opt-out of uploading information to Prime Intellect

@manveerxyz manveerxyz changed the title Feat: Log progress/status to Prime Intellect Feat: Log progress/status to Prime Intellect PRI-442 Sep 10, 2024
@manveerxyz manveerxyz marked this pull request as draft September 10, 2024 01:46
Copy link
Collaborator

@samsja samsja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, I have couples of comments.

I am not too comfortable in adding a prime specific function directly to the hivemind_diloco.py code because we expect people to be able to use open diloco independently from us.

Couples of alternatives:

  • only having pi metrics specific code in the training code train_fsdp.py
  • switch from a push to a pull strategy where the worker just exposes metrics and we run some core periodically on the pi backend to get the metrics. maybe using something like https://github.com/prometheus/client_python
  • make metric pi agnostic and expose it as a feature
  • only keep it for in an internal version

We should avoid global call as much as possible as well:

  • Maximum one function should do a global call something like get_prime_logger and all of the other just call this one
  • or we just skip all global call and just pass the object as parameters

@manveerxyz manveerxyz closed this Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants