-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Verizon Straight Talk Conflict add MMS #128
base: main
Are you sure you want to change the base?
Fix Verizon Straight Talk Conflict add MMS #128
Conversation
Fixed conflict between Verizon and Straight Talk when configuring SMS notifications via Email. Added Verizon MMS option to resolve url clipping in SMS messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Nate,
Thanks for your detailed PR and for your changes. I apologize that you had through the atrocious (on purpose) index.html
. I think your changes are fine, however, I did leave one suggestion.
Is it possible for you to find the MMS addresses for other carriers and add them as well? For testing, we can ask friends and even rely on users.
Thank you!
Hi @Prince25, thanks for reviewing! I can go through and dig up some other carrier MMS addresses and add them in here for sure, will try and do that this weekend. Cheers |
Added MMS addresses for more carriers. Consolidated ATT and FirstNet as well as Xfinity and Virgin Mobile to prevent config file read error. Trimmed stray closing > tag from Vue component template.
As promised @Prince25, pushed those changes! |
Thank you!! It looks good to me. Have you seen what the longer Carrier names look like on the settings page? One final thing would be to update the Email part of the SMS section of the README. Could you just update the carriers and perhaps briefly explain the difference between SMS and MMS? Appreciate it. |
Hey @Prince25, sorry for the delay! Holiday madness set in and I've been slammed. I'm guessing the longer carrier names don't look so great in the Material dropdowns? I'll have some downtime for the holidays starting next week, I can take a look at the visual for the dropdowns and write up some explanation on MMS/SMS too. Cheers! |
Changes
number@vzwpix.com
. I tested and confirmed this sent successfully and included all the information, most importantly the entire product url. It appears there are also MMS addresses for AT&T and other major carriers, unfortunately I can only test Verizon currently.index.html