Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Verizon Straight Talk Conflict add MMS #128

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

curiouscrusher
Copy link

Changes

  • I noticed when saving my SMS via Email notification settings that any recurring visits to the settings page showed "Straight Talk" instead of "Verizon" in the drop down. Turns out they each have the same SMS Email address, so I consolidated both Verizon & Straight Talk into single dropdown option.
  • Verizon SMS Email sends a traditional SMS which has a character limit. Between the subject line, console/store/date/credit info I wasn't even getting half the url to the store page in my text. After some quick testing I found Verizon supports MMS messaging via number@vzwpix.com. I tested and confirmed this sent successfully and included all the information, most importantly the entire product url. It appears there are also MMS addresses for AT&T and other major carriers, unfortunately I can only test Verizon currently.
  • My IDE cleaned up a bunch of extra whitespaces in the index.html

Fixed conflict between Verizon and Straight Talk when configuring SMS notifications via Email. Added Verizon MMS option to resolve url clipping in SMS messages.
@Prince25 Prince25 self-requested a review November 19, 2021 00:42
Copy link
Owner

@Prince25 Prince25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Nate,

Thanks for your detailed PR and for your changes. I apologize that you had through the atrocious (on purpose) index.html. I think your changes are fine, however, I did leave one suggestion.

Is it possible for you to find the MMS addresses for other carriers and add them as well? For testing, we can ask friends and even rely on users.

Thank you!

server/index.html Outdated Show resolved Hide resolved
@curiouscrusher
Copy link
Author

Hi @Prince25, thanks for reviewing! I can go through and dig up some other carrier MMS addresses and add them in here for sure, will try and do that this weekend.

Cheers

Added MMS addresses for more carriers. Consolidated ATT and FirstNet as well as Xfinity and Virgin Mobile to prevent config file read error. Trimmed stray closing > tag from Vue component template.
@curiouscrusher
Copy link
Author

As promised @Prince25, pushed those changes!
I consolidated all carriers that share an address, added all the additional MMS addresses I could find, and updated the tooltip with some notes about the SMS vs MMS sending.

@Prince25
Copy link
Owner

Thank you!! It looks good to me. Have you seen what the longer Carrier names look like on the settings page?

One final thing would be to update the Email part of the SMS section of the README. Could you just update the carriers and perhaps briefly explain the difference between SMS and MMS? Appreciate it.
https://github.com/curiouscrusher/StockAlertBot/blob/b59b7678b6c2e8b7f86a2a2a9ddbfe7b1aecdc26/README.md?plain=1#L173

@curiouscrusher
Copy link
Author

Hey @Prince25, sorry for the delay! Holiday madness set in and I've been slammed.

I'm guessing the longer carrier names don't look so great in the Material dropdowns? I'll have some downtime for the holidays starting next week, I can take a look at the visual for the dropdowns and write up some explanation on MMS/SMS too.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants