Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "requirements: update pytorch requirement from <1.9.0 to <2.0.0" #2408

Merged
merged 1 commit into from
May 10, 2022

Conversation

jvesely
Copy link
Collaborator

@jvesely jvesely commented May 6, 2022

The versioning scheme uses 1.10.y, 1.11.v, ... instead of bumping to
2.0.x.

This reverts commit 70aa492.

The versioning scheme uses 1.10.y, 1.11.v, ... instead of bumping to
2.0.x.

This reverts commit 70aa492.
@jvesely jvesely added the deps Dependency update label May 6, 2022
@jvesely jvesely requested a review from kmantel May 6, 2022 15:05
@jvesely
Copy link
Collaborator Author

jvesely commented May 6, 2022

We're currently restricted by dependencies to 1.8.0 so the exact version doesn't matter.

@github-actions
Copy link

github-actions bot commented May 6, 2022

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@github-actions
Copy link

github-actions bot commented May 6, 2022

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 6, 2022

This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64):

No differences!

...

See CI logs for the full diff.

@kmantel
Copy link
Collaborator

kmantel commented May 10, 2022

ok, this is because the previous bump was done manually, right (#2023)? Reverting is fine. I know https://github.com/ModECI/MDF/ was supposed to remove package caps (including torch) soon, so that might free it on our end.

@jvesely
Copy link
Collaborator Author

jvesely commented May 10, 2022

ok, this is because the previous bump was done manually, right (#2023)? Reverting is fine. I know https://github.com/ModECI/MDF/ was supposed to remove package caps (including torch) soon, so that might free it on our end.

yeah, I wanted a clear revert. we'll see if dependabot can handle regular updates

@jvesely jvesely merged commit a08f1b4 into PrincetonUniversity:devel May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Dependency update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants