llvm: Reduce overhead of compiled parameters #2765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The builder context helpers reset random state if the seed has changed. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
…rs in compiled parametrrs The only provide user interaction, similar to Shared and Function parameters. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
"random_draw", DriftDiffusionIntegrator; only used as a helper for mdf tests. "key_size", "val_size", "max_entries", DictionaryMemory; structural parameters "per_item", TransferFunction; structural parameter "randomization_dimension", GridSearch; user only parameter, not used in compiled code "save_values", "save_samples", GridSearch; structural parameters not used in compiled code "max_iterations", GridSearch; not used by compilation, the number of iterations is known in advance Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
… for cost and intensity parameters These are output parameters that receive new values and can have history enabled. Signed-off-by: Jan Vesely <jan.vesely@rutgers.edu>
|
This PR causes the following changes to the html docs (ubuntu-latest-3.7-x64): See CI logs for the full diff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use get_random_state_ptr helper in GridSearch function instead of accessing the random state directly.
The helper handles reseeding the random state if the seed has changed.
Remove unneeded parameters from compiled structures; read-only parameters with custom getters are user-only and not used in compilation.