Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to https://github.com/coq/coq/pull/19801 #799

Merged

Conversation

andres-erbsen
Copy link
Contributor

@andres-erbsen andres-erbsen commented Nov 3, 2024

I built this with the referenced coq change, and with coq 8.18. I would expect it to build with 8.20, but not with coq master.

@andres-erbsen andres-erbsen changed the title use Z.eqb_eq instead of ?Z.eqb_compare, Zeq_bool_eq (for coq/coq#19801) Adapt to https://github.com/coq/coq/pull/19801 Jan 7, 2025
@proux01
Copy link
Contributor

proux01 commented Jan 9, 2025

Upstream PR coq/coq#19801 merged, please merge this now (we unfortunately had to make this a synchronous overlay, meaning Coq CI will remain broken until this is merged)

@andrew-appel
Copy link
Collaborator

I did not merge it because it was marked as a "draft pull request". Should I mark it as "ready for review" and then merge?

@andres-erbsen andres-erbsen marked this pull request as ready for review January 9, 2025 13:08
@andrew-appel andrew-appel merged commit b19278e into PrincetonUniversity:master Jan 9, 2025
4 checks passed
@andres-erbsen
Copy link
Contributor Author

andres-erbsen commented Jan 9, 2025

(I think yes, for synchronous overlays. With the Coq PR author creating the VST overlay as draft because the Coq PR hasn't been merged yet, and then the Coq PR assignee giving the signal to merge the VST PR, IIUC the assignee can't undraft the VST PR)

@proux01
Copy link
Contributor

proux01 commented Jan 9, 2025

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants