Declare joblib dependency. #477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We depend on joblib, see e.g. `tabpfn.preprocessing`, but currently do not declare this (things still work because scikit-learn depends on it). Specify >=1.2.0, the same as scikit-learn, so the previous minimum version is maintained.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds joblib as an explicit dependency, which is a good practice for ensuring project stability. I have one suggestion to improve the maintainability of the pyproject.toml file by sorting the dependencies list.
priorphil
approved these changes
Sep 2, 2025
Contributor
priorphil
left a comment
priorphil
left a comment
There was a problem hiding this comment.
Should we then import joblib directly instead of going the indirection via sklearn?
Contributor
Author
|
oh I didn't even notice that! Updated |
oscarkey
added a commit
that referenced
this pull request
Nov 12, 2025
* Record copied public PR 477 * Declare joblib dependency. (#477) We depend on joblib, see e.g. tabpfn.preprocessing, but currently do not declare this (things still work because scikit-learn depends on it). Specify >=1.2.0, the same as scikit-learn, so the previous minimum version is maintained. (cherry picked from commit 99c9704) --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: Oscar Key <oscar@priorlabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We depend on joblib, see e.g.
tabpfn.preprocessing, but currently do not declare this (things still work because scikit-learn depends on it).Specify >=1.2.0, the same as scikit-learn, so the previous minimum version is maintained.