Add note to softmax_temperature for the classifier #497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Address possible confusion from the fact that we expose a temperature setting, but use simply `argmax` in `predict`.
|
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds a helpful clarification to the softmax_temperature parameter's docstring in TabPFNClassifier. It correctly points out that this setting does not affect .predict() and is only relevant for .predict_proba() and .predict_logits(). The change is accurate and improves user understanding. I've suggested a minor rephrasing to make the explanation even more direct and clear.
LeoGrin
approved these changes
Sep 9, 2025
Collaborator
LeoGrin
left a comment
LeoGrin
left a comment
There was a problem hiding this comment.
LGTM thanks! I also don't know what "This is only applied when predicting during a post-processing step." but fine to leave it.
Contributor
Author
|
Thanks, Leo! I'll leave refining that latter point for later, but lmk if you think it deserves attention |
oscarkey
pushed a commit
that referenced
this pull request
Nov 12, 2025
…#136) * Record copied public PR 497 * Add note to softmax_temperature for the classifier (#497) Address possible confusion from the fact that we expose a temperature setting, but use simply `argmax` in `predict`. See https://discord.com/channels/1285598202732482621/1412644840667086939/1414888423965196288 (cherry picked from commit da76042) --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address possible confusion from the fact that we expose a temperature setting, but use simply
argmaxinpredict. See https://discord.com/channels/1285598202732482621/1412644840667086939/1414888423965196288