Switch to uv's "--resolution" option to install minimum dependency set. #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies dependency management by removing a custom script and leveraging uv's built-in resolution capabilities. This is a positive change that reduces maintenance overhead. The accompanying update to pyproject.toml to add minimum versions for development dependencies is also a good practice that supports this change. However, a critical oversight is that the test file corresponding to the deleted script, tests/test_scripts.py, has not been removed. This will break the test suite and needs to be addressed.
Previously we used our own script to generate the minimum dependencies. This sometimes went wrong e.g. 534d4c3#diff-64a02d4ff986c9ed55bfeb17ee7f2882087cd60211ddcce8836459941bb95bf9 and it turns out uv has this functionality built in, so use that. I select "lowest-direct", because "lowest" also chooses the minimum versions of transitive dependencies, and these often have no minimum version so we get a very old version. Also add minimum versions to the dev dependencies, which makes "lowest-direct" resolution work nicely when testing locally.
oscarkey
force-pushed
the
ok-uv-dep-spec
branch
from
f00c218 to
7c8fe26
Compare
oscarkey
added a commit
that referenced
this pull request
Nov 12, 2025
…nimum dependency set. (#173) * Record copied public PR 535 * Switch to uv's "--resolution" option to install minimum dependency set. (#535) Previously we used our own script to generate the minimum dependencies to test the compatibility of our package. This doesn't support environment markers, which is blocking my next PR, and has also previously caused issues: 534d4c3#diff-64a02d4ff986c9ed55bfeb17ee7f2882087cd60211ddcce8836459941bb95bf9 uv now has this functionality built in, so replace our script with that. I select "lowest-direct", because "lowest" also chooses the minimum versions of transitive dependencies, and these often have no minimum version so we get very old versions. This also matches the behaviour of the current script. Also add minimum versions to the dev dependencies, which makes "lowest-direct" resolution work nicely when testing locally. This changes the names of the required checks. My plan to force-merge this PR, then change the names of the required checks to the new ones. --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: Oscar Key <oscar@priorlabs.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we used our own script to generate the minimum dependencies to test the compatibility of our package. This doesn't support environment markers, which is blocking my next PR, and has also previously caused issues:
534d4c3#diff-64a02d4ff986c9ed55bfeb17ee7f2882087cd60211ddcce8836459941bb95bf9
uv now has this functionality built in, so replace our script with that.
I select "lowest-direct", because "lowest" also chooses the minimum versions of transitive dependencies, and these often have no minimum version so we get very old versions. This also matches the behaviour of the current script.
Also add minimum versions to the dev dependencies, which makes "lowest-direct" resolution work nicely when testing locally.
This changes the names of the required checks. My plan to force-merge this PR, then change the names of the required checks to the new ones.