-
Notifications
You must be signed in to change notification settings - Fork 538
Rename ModelInterfaceConfig to InferenceConfig. #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Also move it from `tabpfn.config` to `tabpfn.inference_config`, to distinguish this module from all the other config modules we have. We already refer to it as the "inference config" in the classifier/regressor interfaces, so this helps to be consistent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors ModelInterfaceConfig to InferenceConfig and moves it to a new module tabpfn.inference_config. The changes are consistent and well-executed across the codebase. I've found a couple of minor issues: a placeholder in the changelog and an outdated docstring that should be updated to reflect the renaming.
bejaeger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thanks for changing this.
The name of this class was changed in tabpfn in PriorLabs/TabPFN#575
ModelInterfaceConfig was renamed and moved in PriorLabs/TabPFN#575 . This change works with both versions.
) * Record copied public PR 575 * Rename ModelInterfaceConfig to InferenceConfig. (#575) Also move it from `tabpfn.config` to `tabpfn.inference_config`, to distinguish this module from all the other config modules we have. We already refer to it as the "inference config" in the classifier/regressor interfaces, so this helps to be consistent. This changes the public api: - code searches ([1](https://github.com/search?q=org%3APriorLabs+ModelInterfaceConfig+NOT+repo%3APriorLabs%2FTabPFN+NOT+repo%3APriorLabs%2FTabPFN-private+&type=code), [2](https://github.com/search?q=org%3APriorLabs+interface_config_+NOT+repo%3APriorLabs%2FTabPFN+NOT+repo%3APriorLabs%2FTabPFN-private+&type=code)) show one use in tabpfn-extensions and in the tabpfn-client documentation. I will fix these - this could break external users, but as it's a major version upgrade, an easy fix, and probably few people are using it anyway, a quick offline discussion with Noah concluded it's okay --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: Oscar Key <oscar@priorlabs.ai>
Also move it from
tabpfn.configtotabpfn.inference_config, to distinguish this module from all the other config modules we have.We already refer to it as the "inference config" in the classifier/regressor interfaces, so this helps to be consistent.
This changes the public api: