Fix seed for random embeddings on CPU & MPS #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bejaeger
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the seed selection logic for positional embeddings to improve performance on datasets with a small number of features (1-3 features) when using CPU or MPS devices. The change addresses the issue that the default seed optimized for GPU training may be suboptimal for CPU/MPS inference on small-feature datasets.
- Device-specific seed overrides for CPU (819) and MPS (42) are introduced for datasets with few features
- The original
random_embedding_seedfrom config is preserved for GPU devices
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…to ben/fix-seed-for-cpu
oscarkey
pushed a commit
that referenced
this pull request
Nov 12, 2025
* Record copied public PR 592 * Fix seed for random embeddings on CPU & MPS (#592) (cherry picked from commit 94ce690) --------- Co-authored-by: mirror-bot <mirror-bot@users.noreply.github.com> Co-authored-by: Benjamin Jaeger <benjamin@priorlabs.ai> Co-authored-by: Benjamin Jaeger <jaeger.benjamin7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to fix the seed for CPU & MPS inference to one that works for datasets with a small number of features.
This means we also had to update the consistency tests.