Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
There was a problem hiding this comment.
Code Review
This pull request introduces telemetry for model download events from Hugging Face. A new decorator, _log_huggingface_download_errors, is added to wrap the download function, capturing and logging success and failure events. The changes also include updating the tabpfn-common-utils dependency to a newer version that supports this telemetry.
The implementation is functionally correct. My main feedback is to refactor the new decorator to improve clarity and reduce its coupling with the decorated function, as it currently modifies the arguments passed to it. This will make the code easier to understand and maintain.
noahho
left a comment
There was a problem hiding this comment.
Not sure if this one is meant to help us understand HuggingFace Gating and if users struggle with that? If yes, I don't think it measures the right stats (time from error to resolution, which steps people took (e.g. are they logged in HF? Did they accept gating?) I'd drive this more from actual data we can interpret?). If no, what is the goal if this measurement.
Issue
With this PR we set up logging failed and successful model loading events into our telemetry system. These are logged anonymously to identify common reasons for failure and further improve the user experience.
Do not merge this PR until a new
tabpfn_common_utilspackage is released.Motivation and Context
Public API Changes
How Has This Been Tested?
Locally.
Checklist
changelog/README.md), or "no changelog needed" label requested.