Skip to content

Update finetuned_regressor.py#772

Open
jonaslandsgesell wants to merge 5 commits intoPriorLabs:mainfrom
jonaslandsgesell:patch-1
Open

Update finetuned_regressor.py#772
jonaslandsgesell wants to merge 5 commits intoPriorLabs:mainfrom
jonaslandsgesell:patch-1

Conversation

@jonaslandsgesell
Copy link
Contributor

Pass through kwargs,

Motivation and Context

e.g. needed for finetuned_reg.predict(X_test, output_type='full')


Public API Changes

  • No Public API changes
  • [x ] Yes, Public API changes (Details below)

Checklist

  • [x ] The changes have been tested locally.
  • Documentation has been updated (if the public API or usage changes).
  • A changelog entry has been added (see changelog/README.md), or "no changelog needed" label requested.
  • The code follows the project's style guidelines.
  • I have considered the impact of these changes on the public API.

Pass through kwargs, e.g. needed for finetuned_reg.predict(X_test, output_type='full')
@jonaslandsgesell jonaslandsgesell requested a review from a team as a code owner February 3, 2026 08:00
@jonaslandsgesell jonaslandsgesell requested review from adrian-prior and removed request for a team February 3, 2026 08:00
@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ jonaslandsgesell
❌ Jonas Landsgesell


Jonas Landsgesell seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for passing keyword arguments to the predict method of FinetunedTabPFNRegressor, which is a good enhancement for flexibility. My review focuses on ensuring the type hints are updated to reflect the new capabilities. I've identified that the return type of predict is now incorrect given the new arguments and have suggested a fix to make it accurate.

jonaslandsgesell and others added 3 commits February 3, 2026 09:05
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@adrian-prior
Copy link

@jonaslandsgesell Thanks for the PR! The changes look correct to me, but you can see in the failing tests that there are a few things missing (changelog, formatting, etc.). Please add these and them I happy to give it a proper review :)

@adrian-prior
Copy link

adrian-prior commented Feb 3, 2026

@jonaslandsgesell Also, have you already signed the CLA? See the bot commenting above. In addition, I think you also might have incorrectly formatted the changelog (see the changelog test on how to correctly add that)

@adrian-prior
Copy link

@jonaslandsgesell Have you already signed the CLA? The test still indicates that it hasn't been signed.

@jonaslandsgesell
Copy link
Contributor Author

@jonaslandsgesell Have you already signed the CLA? The test still indicates that it hasn't been signed.

Yes I signed with this GitHub account.

Copy link

@adrian-prior adrian-prior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, the changes look good to me. Please also modify predict and predict_prob in the FinetunedClassifier accordingly. Regarding the CLA:
I think some of the commits aren't associated with your GitHub Account. Hopefully, I can merge the PR without the CLA test passing. Otherwise, there seems to be an option to add the correct email in retrospect.

@jonaslandsgesell
Copy link
Contributor Author

As far as I see, the predict and predict_proba method in the TabPFNClassifier do not seem to currently take additional keyword arguments. Do you want me to still add the kwargs parameters?

@adrian-prior
Copy link

@jonaslandsgesell Good spot. I would still go for it. Could very well be the case that this will change soon :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants