Custom Class plugin broken #1137
Comments
|
The first issue seems normal: Custom class names don't also rewrite the CSS files, you would need to do that manually based on your prefix. |
What do you mean exactly. What do I modify in the CSS files? I assume you mean I have to rename some classes to use prefixes. But how do I know all the style classes Prism uses? How do I know what to rename? Do I rename everything? Or just the |
It would seem to me that anything reproduces it. Have you tried to reproduce this? Here is a simple test case using the "coy" theme, all languages, and the following plugins:
I then modified the Prism.plugins.customClass.prefix('prism-');Here is the test case: <?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE html>
<html lang="en-US" xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta charset="UTF-8" />
<title>Prism Bug #1137 Demo with JAX-RS</title>
<meta name="author" content="Garret Wilson" />
<link type="text/css" rel="stylesheet" href="css/prism.css" />
</head>
<body>
<pre class="line-numbers"><code class="language-java">@ApplicationPath("/foo/")
public class FooApplication extends Application {
@Override
public Set<Class<?>> getClasses() {
return ImmutableSet.of(BarResourceService.class); //implementation of BarResource
}
}</code></pre>
<script src="../js/prism.js"></script>
</body>
</html>Yes, I even replaced all |
|
I've posted a bounty for someone to fix this: https://www.bountysource.com/issues/45180945-custom-class-plugin-broken |
When the classMap is accessed, it is undefined, causing this look up to fail. Defaulting it to an empty object provides the right logic. https://github.com/PrismJS/prism/blob/16ce4b336d625e13065bfc12ab6d13ac862d6f50/plugins/custom-class/prism-custom-class.js#L25
|
@garretwilson I've put in a PR for this. Let me know if it fixes it for you. |
|
@jimmyhmiller, sorry for the delay --- a few days of vacation with no good Internet connection, work, traveling, etc. But I think your fix works!! I created my exact test case above and downloaded the latest published Prism code. I followed my own directions, and the error no longer occurs! Moreover I'm seeing that Prism is generating the prefix I asked for. As a test I renamed some of the selectors in the Prism CSS, and they styled the new classes. This whole thing is less important to me now that I found out (see #1055 (comment)) that I can unselect Thanks, @jimmyhmiller ! I'll go figure out how to assign the bounty now. |
I have my own style class
annotation, which makes a little note icon appear in the text. As I explained elsewhere, this makes my<pre class="line-numbers"><code class="language-java">sections have little note icons all over the place, because Prism hijacks the common nameannotationfor its own purposes (not bothering to prefix its style names to even attempt to avoid clashes).I had hoped the custom class plugin would provide a workaround. I downloaded (minified) Prism with the "coy" theme, all languages, and the following plugins:
Then I edited
prism.jsand added the following line at the end, as per the custom class plugin documentation:On my first code block, the little note icons disappeared. The coy theme remained, but there was no Java syntax highlighting.
My second code block had no formatting at all --- not even the coy theme.
The Chrome console says:
The text was updated successfully, but these errors were encountered: