-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis: Fail when changed files are detected #1819
Travis: Fail when changed files are detected #1819
Conversation
This is for testing purposes
This should work again
Alright, it failed when some generated files were changed and it succeeds when Prism is built properly. Seems to work. |
Love the idea. Two nits:
|
Alright, funny story: The build fails because some minified files changed. I had to make a fresh npm installation until these files also changed on my system. So yeah. With the current state of this PR, the success of our builds will be at the mercy of Uglify's minification behavior. Maybe it's time for a |
Yeah, and we'll need to update the install step to use |
Minor problem: The npm version of Node v6 doesn't support |
Upgrade |
Updating to the latest npm version works but it feels kind of hacky... Well, anyway. @mAAdhaTTah, you might want to take another look at this PR. |
This works for me. Since we're only updating to use |
This resolves #1785.
I'll make some testing on this PR, so there might be some failed tests here and there. I'll comment again when I'm ready.