Make ERB, Handlebars, PHP and Smarty highlight properly in NodeJS #1367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since ERB, Handlebars, PHP and Smarty currently rely on
before-highlight
andafter-highlight
hooks to be highlighted properly, they can't be easily highlighted using directly thePrism.highlight()
function.#1357 added the
after-tokenize
hook to post-process tokens directly in thePrism.highlight()
function. This PR adds abefore-tokenize
hook, and essentially translates what we were previously doing with string replacement, but using the array of tokens.This should remove the need for the
backupCode
/before-insert
hack, since the code is properly tokenized at the end of thehighlight()
function.I also converted the tests from
.js
format to.test
format, since the test runner can now run them normally.