Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download page #1484

Merged
merged 2 commits into from
Jul 21, 2018
Merged

Download page #1484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f6c4a
Cleaned up download page
RunDevelopment Jul 16, 2018
3f687d6
Fixed brittle selector
RunDevelopment Jul 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 27 additions & 13 deletions download.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,25 @@
form label {
display: block;
padding: .2em;
padding-left: 1.9em;
page-break-inside: avoid;
break-inside: avoid;
-webkit-column-break-inside: avoid;
}

form input {
margin-right: .7em;
}
form label .name {
margin-right: .3em;
}

form label a.owner {
margin-left: 0;
hyphens: none;
}

form label input {
margin-right: .7em;
margin-left: -1.7em;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS you added appears indented further than the code around it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, because it is about elements inside form label, so it gets indented.
This practice can also be seen further down below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, that works.


form > p:first-of-type > label {
font-size: 150%;
Expand All @@ -24,7 +38,7 @@
form > p:first-of-type > label input {
vertical-align: .3em;
}

.filesize:empty {
display: none;
}
Expand Down Expand Up @@ -113,7 +127,7 @@
border-top-right-radius: 0;
border-bottom-right-radius: 0;
}

#download-css .download-button {
background-color: #dc9e23;
border-top-left-radius: 0;
Expand All @@ -129,7 +143,7 @@

<header>
<div class="intro" data-src="templates/header-main.html" data-type="text/html"></div>

<h2>Customize your download</h2>
<p>Select your compression level, as well as the languages and plugins you need.</p>
</header>
Expand All @@ -141,29 +155,29 @@ <h2>Customize your download</h2>
<label><input type="radio" name="compression" value="0" /> Development version</label>
<label><input type="radio" name="compression" value="1" checked /> Minified version</label>
</p>

<section id="components"></section>

<p>
Total filesize: <strong id="filesize"></strong> (<strong id="percent-js"></strong> JavaScript + <strong id="percent-css"></strong> CSS)
</p>
<p><strong>Note:</strong> The filesizes displayed refer to non-gizipped files and include any CSS code required. The CSS code is not minified.</p>

<section id="download">
<div class="error"></div>
<section id="download-js" class="download">
<pre><code class="language-javascript"></code></pre>
<a href="#" class="download-button" download="prism.js" target="_blank">Download JS</a>
</section>

<section id="download-css" class="download">
<pre><code class="language-css"></code></pre>
<a href="#" class="download-button" download="prism.css" target="_blank">Download CSS</a>
</section>
</section>

</form>

</section>

<footer data-src="templates/footer.html" data-type="text/html"></footer>
Expand All @@ -176,4 +190,4 @@ <h2>Customize your download</h2>
<script src="download.js"></script>

</body>
</html>
</html>
14 changes: 11 additions & 3 deletions download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,10 +220,18 @@ for (var category in components) {
all.meta.link? {
tag: 'a',
properties: {
href: all.meta.link.replace(/\{id}/g, id)
href: all.meta.link.replace(/\{id}/g, id),
className: 'name'
},
contents: info.title
} : info.title,
} : {
tag: 'span',
properties: {
className: 'name'
},
contents: info.title
},
' ',
all[id].owner? {
tag: 'a',
properties: {
Expand Down Expand Up @@ -574,4 +582,4 @@ function getVersion() {
});
}

})();
})();