Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smalltalk: Allowed empty strings and comments #1747

Merged
merged 2 commits into from
Feb 28, 2019

Conversation

RunDevelopment
Copy link
Member

This PR fixes #1746 and empty comments.

@bencoman
Copy link
Contributor

@RunDevelopment, Thanks for the prompt response. I see your regex changes - they make perfect sense, so it should work but I'm not sure the best way to test it in practice to observe the highlighting. (P.S. it would be cool if all I needed to do was pull down a menu at https://prismjs.com/test.html to select the PR, and it loaded the language files direct from the PR.)

@RunDevelopment
Copy link
Member Author

P.S. it would be cool if all I needed to do was pull down a menu at https://prismjs.com/test.html to select the PR, and it loaded the language files direct from the PR.

That's a pretty cool idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smalltalk empty string not handled correctly
2 participants