Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby/ERB: Fixed block comments #1768

Merged
merged 2 commits into from
Mar 5, 2019
Merged

Ruby/ERB: Fixed block comments #1768

merged 2 commits into from
Mar 5, 2019

Conversation

RunDevelopment
Copy link
Member

This PR fixes #1767.

  • Added support for block comments containing closing tags.
  • Ruby block comments can now have text after =begin. E.g. 
    =begin foo
=end

Example

image

@RunDevelopment RunDevelopment merged commit c805f85 into PrismJS:master Mar 5, 2019
@RunDevelopment RunDevelopment deleted the erb-block-comments branch March 5, 2019 15:56
@olets
Copy link

olets commented Mar 5, 2019

Thanks @RunDevelopment 👏

This was referenced Oct 26, 2019
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 8, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug language-definitions needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support block comments in erb
2 participants
@RunDevelopment @olets