-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for NaniScript #2494
Conversation
…me; feat: multiple allow tabs & spaces before labels and comments
feat: add command param value token; fix: highlight inline command name...
fix: CI issues
Sorry for the ongoing commits; it's ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this pull request @elringus!
There are a few things we have to do before we can merge this.
I think it's largely ok as is (I looked at your documentation page and the highlight looks really good) but there a few smaller things we have to do (mostly simplifying and optimizing the regexes).
Also, you don't have to do these alone. If it's ok with you, then I'll make a PR to your branch that will include some of my suggestions.
Thank you for the review! @vladdancer is actually the main contributor here, hopefully he'll be able to provide some feedback on the suggestions. A PR to the fork would be great, thanks! |
Quick question: How does escaping in strings work? The doc gives this example:
But I guess that this isn't how it is supposed to be tokenized:
So how does it work? It's not mentioned anywhere and the double escaping seems weird to me. |
That's a special case here. The value of |
I see. Since doing this correctly will be quite difficult, let's just leave it as is. |
Naniscript improvements
@RunDevelopment thank you for a such great review! |
Fix misc issues: new line, correct regex, right tests descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes @vladdancer and @elringus!
I still have some minor nits but after those, it's ready to go.
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Thank you for contributing @elringus and @vladdancer! |
Thank you for the help and patience with us! |
@RunDevelopment Thanks one more time for such great review, it gives me more details about regular expressions! |
NaniScript is a scenario scripting language used by Naninovel visual novel extension for Unity: https://naninovel.com