Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Add match keyword in PHP 8.0 #2574

Merged
merged 2 commits into from
Oct 5, 2020
Merged

[PHP] Add match keyword in PHP 8.0 #2574

merged 2 commits into from
Oct 5, 2020

Conversation

Ayesh
Copy link
Contributor

@Ayesh Ayesh commented Oct 4, 2020

PHP introduces a new match keyword in PHP 8.0.
This commit updates the keywords list for PHP language component to add match to it.

Thank you.

PHP introduces a new [`match` keyword in PHP 8.0](https://php.watch/versions/8.0/match-expression).
This commit updates the keywords list for PHP language component to add `match` to it.
Copy link
Member

@RunDevelopment RunDevelopment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this pull.

Please also add this keyword to PHP's keyword test.

@Ayesh
Copy link
Contributor Author

Ayesh commented Oct 4, 2020

Thanks a lot for the quick response @RunDevelopment , I will make changes there soon. I apologize for not having it in one go.

@Ayesh
Copy link
Contributor Author

Ayesh commented Oct 4, 2020

I updated the tests @RunDevelopment. Thank you.

@RunDevelopment RunDevelopment merged commit 1761513 into PrismJS:master Oct 5, 2020
@RunDevelopment
Copy link
Member

Thank you for contributing @Ayesh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants